phet commented on code in PR #4047:
URL: https://github.com/apache/gobblin/pull/4047#discussion_r1747513712
##########
gobblin-temporal/src/main/java/org/apache/gobblin/temporal/ddm/work/CleanupResult.java:
##########
@@ -26,12 +26,12 @@
/**
- * Data structure representing the stats for a cleaned up work directory,
where it returns a list of directories it cleaned up and their size
+ * Data structure representing the stats for a cleaned up work directory,
where it returns a map of directories the result of their cleanup
*/
@Data
@NoArgsConstructor // IMPORTANT: for jackson (de)serialization
@RequiredArgsConstructor
public class CleanupResult {
- @NonNull private Map<String, Long> cleanupSummary;
+ @NonNull private Map<String, Boolean> attemptedCleanedDirectories;
Review Comment:
may we just term this deletion? "cleanup" could mean any number of things -
e.g.
* retaining only "useful" files and getting rid of "junk" - for whatever
definition of useful/junk
* getting rid of "partial" files and keeping only complete ones
also, `attemptedCleanedDirectories`, even if named `attemptedDirDeletions`,
does not capture the semantics of that `Boolean`. how about
`deletionSuccessesByDirPath`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
