[
https://issues.apache.org/jira/browse/GOBBLIN-2136?focusedWorklogId=933870&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-933870
]
ASF GitHub Bot logged work on GOBBLIN-2136:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 09/Sep/24 21:00
Start Date: 09/Sep/24 21:00
Worklog Time Spent: 10m
Work Description: phet commented on code in PR #4041:
URL: https://github.com/apache/gobblin/pull/4041#discussion_r1750660625
##########
gobblin-service/src/main/java/org/apache/gobblin/service/monitoring/DagActionStoreChangeMonitor.java:
##########
@@ -114,7 +114,6 @@ Metrics need to be created before initializeMonitor() below
is called (or more s
protected void assignTopicPartitions() {
// Expects underlying consumer to handle initializing partitions and
offset for the topic -
// subscribe to all partitions from latest offset
Review Comment:
I'm a bit fuzzy on this (and wondering whether it should be an `abstract`
method).
if the empty but concrete impl is actually what we want, is it possible to
identify the specific method involved in the "underlying consumer"?
Issue Time Tracking
-------------------
Worklog Id: (was: 933870)
Time Spent: 7h 50m (was: 7h 40m)
> remove obsolete code related to DagManager
> ------------------------------------------
>
> Key: GOBBLIN-2136
> URL: https://issues.apache.org/jira/browse/GOBBLIN-2136
> Project: Apache Gobblin
> Issue Type: Task
> Reporter: Arjun Singh Bora
> Priority: Major
> Time Spent: 7h 50m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
