[
https://issues.apache.org/jira/browse/GOBBLIN-2136?focusedWorklogId=934085&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-934085
]
ASF GitHub Bot logged work on GOBBLIN-2136:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 10/Sep/24 20:17
Start Date: 10/Sep/24 20:17
Worklog Time Spent: 10m
Work Description: arjun4084346 commented on code in PR #4041:
URL: https://github.com/apache/gobblin/pull/4041#discussion_r1752670124
##########
gobblin-restli/gobblin-flow-config-service/gobblin-flow-config-service-server/src/main/java/org/apache/gobblin/service/modules/restli/FlowConfigsV2ResourceHandler.java:
##########
@@ -164,16 +165,14 @@ public UpdateResponse partialUpdateFlowConfig(FlowId
flowId,
return updateFlowConfig(flowId, flowConfig, modifiedWatermark);
}
- public UpdateResponse updateFlowConfig(FlowId flowId,
- FlowConfig flowConfig) throws FlowConfigLoggedException {
+ public UpdateResponse updateFlowConfig(FlowId flowId, FlowConfig flowConfig)
throws FlowConfigLoggedException {
// We have modifiedWatermark here to avoid update config happens at the
same time on different hosts overwrite each other
// timestamp here will be treated as largest modifiedWatermark that we can
update
long version = System.currentTimeMillis() / 1000;
return updateFlowConfig(flowId, flowConfig, version);
}
- public UpdateResponse updateFlowConfig(FlowId flowId,
- FlowConfig flowConfig, long modifiedWatermark) throws
FlowConfigLoggedException {
+ private UpdateResponse updateFlowConfig(FlowId flowId, FlowConfig
flowConfig, long modifiedWatermark) throws FlowConfigLoggedException {
Review Comment:
no, it did not exist in older `FlowConfigsResourceHandler` interface. it
could be private so changed it to private
Issue Time Tracking
-------------------
Worklog Id: (was: 934085)
Time Spent: 9h 10m (was: 9h)
> remove obsolete code related to DagManager
> ------------------------------------------
>
> Key: GOBBLIN-2136
> URL: https://issues.apache.org/jira/browse/GOBBLIN-2136
> Project: Apache Gobblin
> Issue Type: Task
> Reporter: Arjun Singh Bora
> Priority: Major
> Time Spent: 9h 10m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
