phet commented on code in PR #4049:
URL: https://github.com/apache/gobblin/pull/4049#discussion_r1750964026
##########
gobblin-restli/gobblin-flow-config-service/gobblin-flow-config-service-api/src/main/pegasus/org/apache/gobblin/service/ExecutionStatus.pdl:
##########
@@ -49,4 +49,9 @@ enum ExecutionStatus {
* Flow cancelled.
*/
CANCELLED
+
+ /**
+ * Flow or job is skipped
Review Comment:
how would a flow be skipped? wouldn't the flow instead be CANCELLED or
FAILED? after that (fewer than all of) that flow's jobs may be SKIPPED (fewer,
because at least one would be CANCELLED or FAILED)
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/DagUtils.java:
##########
@@ -164,7 +164,8 @@ public static Set<DagNode<JobExecutionPlan>>
getNext(Dag<JobExecutionPlan> dag)
DagNode<JobExecutionPlan> node = nodesToExpand.poll();
ExecutionStatus executionStatus = getExecutionStatus(node);
boolean addFlag = true;
- if (executionStatus == PENDING || executionStatus == PENDING_RETRY ||
executionStatus == PENDING_RESUME) {
+ if (executionStatus == PENDING || executionStatus == PENDING_RETRY ||
executionStatus == PENDING_RESUME ||
+ executionStatus == SKIPPED) {
Review Comment:
I'm unclear here: is "skipping" able to be reversed, so the node can later
be ready? (I'm equating `getNext` to identifying the set of "ready" nodes.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
