arjun4084346 commented on code in PR #4049:
URL: https://github.com/apache/gobblin/pull/4049#discussion_r1755536308
##########
gobblin-service/src/main/java/org/apache/gobblin/service/monitoring/KafkaJobStatusMonitor.java:
##########
@@ -116,7 +116,7 @@ public abstract class KafkaJobStatusMonitor extends
HighLevelConsumer<byte[], by
private static final List<ExecutionStatus> ORDERED_EXECUTION_STATUSES =
ImmutableList
.of(ExecutionStatus.COMPILED, ExecutionStatus.PENDING,
ExecutionStatus.PENDING_RESUME, ExecutionStatus.PENDING_RETRY,
- ExecutionStatus.ORCHESTRATED, ExecutionStatus.RUNNING,
ExecutionStatus.COMPLETE,
+ ExecutionStatus.ORCHESTRATED, ExecutionStatus.RUNNING,
ExecutionStatus.SKIPPED, ExecutionStatus.COMPLETE,
Review Comment:
these four are the terminal statuses and once a job reaches here, further
GTEs can be ignored.
we also do not expect to see two of them for the same job.
yes, there can be some combinations of events among these four, that may
arrive due to race condition, but i think, in that case, it is ok for GaaS to
just adhere to any of the ordering. I do not want to change the correct
ordering, so I added SKIPPED before other terminal statuses, to basically
support the same idea of yours - let it show complete if it is
cancelled/skipped earlier.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
