[
https://issues.apache.org/jira/browse/GOBBLIN-2151?focusedWorklogId=933881&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-933881
]
ASF GitHub Bot logged work on GOBBLIN-2151:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 09/Sep/24 23:00
Start Date: 09/Sep/24 23:00
Worklog Time Spent: 10m
Work Description: arjun4084346 commented on code in PR #4050:
URL: https://github.com/apache/gobblin/pull/4050#discussion_r1751035101
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/utils/FlowCompilationValidationHelper.java:
##########
@@ -187,9 +194,59 @@ public Optional<Dag<JobExecutionPlan>>
validateAndHandleConcurrentExecution(Conf
* @param allowConcurrentExecution
* @return true if the {@link FlowSpec} allows concurrent executions or if
no other instance of the flow is currently RUNNING.
*/
- private boolean isExecutionPermitted(FlowStatusGenerator
flowStatusGenerator, String flowGroup, String flowName,
- boolean allowConcurrentExecution, long flowExecutionId) {
- return allowConcurrentExecution ||
!flowStatusGenerator.isFlowRunning(flowName, flowGroup, flowExecutionId);
+ private boolean isExecutionPermitted(String flowGroup, String flowName,
boolean allowConcurrentExecution)
+ throws IOException {
+ return allowConcurrentExecution || !isFlowRunning(flowGroup, flowName,
dagManagementStateStore);
+ }
+
+ /**
+ * Returns true if any previous execution for the flow determined by the
provided flowGroup, flowName is running.
+ * We ignore the execution that has the provided flowExecutionId. We also
ignore the flows that are running beyond
Review Comment:
oh yea, i missed this explaining about this.
So, I do not understand why the previous code in
`FlowStatusGenerator::isFlowRunning` ignores existing flow statuses of the
current `flowExecutionId`. Shouldnt we skip the job if the a flow with the
current flowExecutionId is already running? @Will-Lo you may have some idea.
Issue Time Tracking
-------------------
Worklog Id: (was: 933881)
Time Spent: 0.5h (was: 20m)
> ignore flows that are running beyond job start and flow finish deadline
> -----------------------------------------------------------------------
>
> Key: GOBBLIN-2151
> URL: https://issues.apache.org/jira/browse/GOBBLIN-2151
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: Arjun Singh Bora
> Priority: Major
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
