[
https://issues.apache.org/jira/browse/GOBBLIN-2151?focusedWorklogId=934112&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-934112
]
ASF GitHub Bot logged work on GOBBLIN-2151:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 10/Sep/24 23:24
Start Date: 10/Sep/24 23:24
Worklog Time Spent: 10m
Work Description: arjun4084346 commented on code in PR #4050:
URL: https://github.com/apache/gobblin/pull/4050#discussion_r1752928707
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/utils/FlowCompilationValidationHelper.java:
##########
@@ -187,9 +194,59 @@ public Optional<Dag<JobExecutionPlan>>
validateAndHandleConcurrentExecution(Conf
* @param allowConcurrentExecution
* @return true if the {@link FlowSpec} allows concurrent executions or if
no other instance of the flow is currently RUNNING.
*/
- private boolean isExecutionPermitted(FlowStatusGenerator
flowStatusGenerator, String flowGroup, String flowName,
- boolean allowConcurrentExecution, long flowExecutionId) {
- return allowConcurrentExecution ||
!flowStatusGenerator.isFlowRunning(flowName, flowGroup, flowExecutionId);
+ private boolean isExecutionPermitted(String flowGroup, String flowName,
boolean allowConcurrentExecution)
+ throws IOException {
+ return allowConcurrentExecution || !isFlowRunning(flowGroup, flowName,
dagManagementStateStore);
+ }
+
+ /**
+ * Returns true if any previous execution for the flow determined by the
provided flowGroup, flowName is running.
+ * We ignore the execution that has the provided flowExecutionId. We also
ignore the flows that are running beyond
Review Comment:
Okay, thanks for the explanation. I think with this in mind, it looks ok to
consider all execution ids including the current one. This method will be
called only by the lease owner and that is supposed to start the flow, if it
does, but somehow fails to finish the lease (service restart, or anything), it
is expected for the next lease owner to understand that the flow is launched
and not re-launch it. cc @phet
Issue Time Tracking
-------------------
Worklog Id: (was: 934112)
Time Spent: 1h 50m (was: 1h 40m)
> ignore flows that are running beyond job start and flow finish deadline
> -----------------------------------------------------------------------
>
> Key: GOBBLIN-2151
> URL: https://issues.apache.org/jira/browse/GOBBLIN-2151
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: Arjun Singh Bora
> Priority: Major
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
