[
https://issues.apache.org/jira/browse/GOBBLIN-2151?focusedWorklogId=934326&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-934326
]
ASF GitHub Bot logged work on GOBBLIN-2151:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 11/Sep/24 18:26
Start Date: 11/Sep/24 18:26
Worklog Time Spent: 10m
Work Description: phet commented on code in PR #4050:
URL: https://github.com/apache/gobblin/pull/4050#discussion_r1755294130
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/utils/FlowCompilationValidationHelper.java:
##########
@@ -217,13 +219,21 @@ static boolean isFlowBeforeThisExecutionRunning(String
flowGroup, String flowNam
}
for (FlowStatus flowStatus : flowStatusList) {
+ ExecutionStatus flowExecutionStatus =
flowStatus.getFlowExecutionStatus();
if (flowStatus.getFlowExecutionId() == flowExecutionId) {
// a duplicate call to this method indicate that the prior caller of
this method could not complete the required action,
// so we ignore any flow status for the current execution to give the
caller another chance to complete them
+ // but this should be rate, so lets log it
+ if (flowExecutionStatus == COMPILED) {
+ log.info("A previous execution with the same flowExecutionId found
{}. Previous execution may not be "
+ + "successfully submitted.", flowStatus);
+ } else if (flowExecutionStatus == RUNNING) {
+ log.error("A previous execution with the same flowExecutionId found
{}. This is a rare case of previous "
+ + "execution getting submitted but then LaunchDagProc failed to
complete the lease", flowStatus);
+ }
Review Comment:
unexpected though it may be, to avoid any other status slipping through the
cracks, let's log all others as `.warn`
Issue Time Tracking
-------------------
Worklog Id: (was: 934326)
Time Spent: 3h 40m (was: 3.5h)
> ignore flows that are running beyond job start and flow finish deadline
> -----------------------------------------------------------------------
>
> Key: GOBBLIN-2151
> URL: https://issues.apache.org/jira/browse/GOBBLIN-2151
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: Arjun Singh Bora
> Priority: Major
> Time Spent: 3h 40m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
