[ https://issues.apache.org/jira/browse/GOBBLIN-2135?focusedWorklogId=934355&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-934355 ]
ASF GitHub Bot logged work on GOBBLIN-2135: ------------------------------------------- Author: ASF GitHub Bot Created on: 11/Sep/24 20:15 Start Date: 11/Sep/24 20:15 Worklog Time Spent: 10m Work Description: Will-Lo commented on code in PR #4030: URL: https://github.com/apache/gobblin/pull/4030#discussion_r1755527804 ########## gobblin-yarn/src/main/java/org/apache/gobblin/yarn/YarnHelixUtils.java: ########## @@ -199,6 +203,18 @@ public static void setYarnClassPath(Config config, Configuration yarnConfigurati } } + public static Path getJarPathCacheAndCleanIfNeeded(Config config, FileSystem fs) throws IOException { Review Comment: I set retainKLatestCachePaths to return false if any deletion failed rather than true iff there were any deletions, but this was a good idea. Issue Time Tracking ------------------- Worklog Id: (was: 934355) Time Spent: 1h (was: 50m) > Cache Yarn jars in GobblinYarnAppLauncher > ----------------------------------------- > > Key: GOBBLIN-2135 > URL: https://issues.apache.org/jira/browse/GOBBLIN-2135 > Project: Apache Gobblin > Issue Type: Improvement > Reporter: William Lo > Priority: Major > Time Spent: 1h > Remaining Estimate: 0h > > Gobblin YARN Application Launcher lacks some functionality used in > MRJobLauncher. One of the biggest gaps in feature parity is the absence of > jar caching, where MRJobLauncher creates a monthly cache that is > automatically cleaned up by subsequent executions performed 2 months in > advance. > YARN/MR requires uploading jars to HDFS, this step can be quite slow (~15 > mins for a sizeable job to get all the jars), and given that many jobs do > share the same jars, it makes sense to cache them together and only provide > YARN the shared path. > We also want to ensure that SNAPSHOT jars are other files are not uploaded to > a cache, since they are not immutable unlike jar versions on Artifactory. -- This message was sent by Atlassian Jira (v8.20.10#820010)