[ https://issues.apache.org/jira/browse/GOBBLIN-2135?focusedWorklogId=934583&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-934583 ]
ASF GitHub Bot logged work on GOBBLIN-2135: ------------------------------------------- Author: ASF GitHub Bot Created on: 12/Sep/24 17:57 Start Date: 12/Sep/24 17:57 Worklog Time Spent: 10m Work Description: codecov-commenter commented on PR #4030: URL: https://github.com/apache/gobblin/pull/4030#issuecomment-2346915466 ## [Codecov](https://app.codecov.io/gh/apache/gobblin/pull/4030?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report All modified and coverable lines are covered by tests :white_check_mark: > Project coverage is 55.31%. Comparing base [(`e501b62`)](https://app.codecov.io/gh/apache/gobblin/commit/e501b62ffe646885d8b33198737bc16d38c04ba3?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`72eb403`)](https://app.codecov.io/gh/apache/gobblin/commit/72eb403d117db10aec4f069169caa13b0bb41b5f?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). > Report is 23 commits behind head on master. <details><summary>Additional details and impacted files</summary> ```diff @@ Coverage Diff @@ ## master #4030 +/- ## ============================================ + Coverage 45.86% 55.31% +9.45% + Complexity 3257 1582 -1675 ============================================ Files 707 307 -400 Lines 27865 10580 -17285 Branches 2796 1069 -1727 ============================================ - Hits 12779 5852 -6927 + Misses 14008 4223 -9785 + Partials 1078 505 -573 ``` </details> [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/gobblin/pull/4030?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). Issue Time Tracking ------------------- Worklog Id: (was: 934583) Time Spent: 1h 40m (was: 1.5h) > Cache Yarn jars in GobblinYarnAppLauncher > ----------------------------------------- > > Key: GOBBLIN-2135 > URL: https://issues.apache.org/jira/browse/GOBBLIN-2135 > Project: Apache Gobblin > Issue Type: Improvement > Reporter: William Lo > Priority: Major > Time Spent: 1h 40m > Remaining Estimate: 0h > > Gobblin YARN Application Launcher lacks some functionality used in > MRJobLauncher. One of the biggest gaps in feature parity is the absence of > jar caching, where MRJobLauncher creates a monthly cache that is > automatically cleaned up by subsequent executions performed 2 months in > advance. > YARN/MR requires uploading jars to HDFS, this step can be quite slow (~15 > mins for a sizeable job to get all the jars), and given that many jobs do > share the same jars, it makes sense to cache them together and only provide > YARN the shared path. > We also want to ensure that SNAPSHOT jars are other files are not uploaded to > a cache, since they are not immutable unlike jar versions on Artifactory. -- This message was sent by Atlassian Jira (v8.20.10#820010)