Blazer-007 commented on code in PR #4058:
URL: https://github.com/apache/gobblin/pull/4058#discussion_r1810719341
##########
gobblin-data-management/src/test/java/org/apache/gobblin/data/management/copy/iceberg/IcebergTableTest.java:
##########
@@ -106,15 +113,17 @@ public void testGetCurrentSnapshotInfo() throws
IOException {
);
initializeSnapshots(table, perSnapshotFilesets);
- IcebergSnapshotInfo snapshotInfo = new IcebergTable(tableId,
catalog.newTableOps(tableId), catalogUri).getCurrentSnapshotInfo();
+ IcebergSnapshotInfo snapshotInfo = new IcebergTable(tableId,
catalog.newTableOps(tableId), catalogUri,
+ catalog.loadTable(tableId)).getCurrentSnapshotInfo();
verifySnapshotInfo(snapshotInfo, perSnapshotFilesets,
perSnapshotFilesets.size());
}
/** Verify failure when attempting to get current snapshot info for
non-existent table */
- @Test(expectedExceptions = IcebergTable.TableNotFoundException.class)
+ @Test(expectedExceptions = {IcebergTable.TableNotFoundException.class,
NoSuchTableException.class})
Review Comment:
to throw` IcebergTable.TableNotFoundException.class` exception I can change
catalog.loadTable(tableIdentifier) to null as `NoSuchTableException.class`
comes from catalog.loadTable(tableIdentifier) and catalog here comes from
HiveMetastoreTest and is not our catalogImplementation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@gobblin.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
