phet commented on code in PR #4058:
URL: https://github.com/apache/gobblin/pull/4058#discussion_r1811463854


##########
gobblin-data-management/src/main/java/org/apache/gobblin/data/management/copy/iceberg/BaseIcebergCatalog.java:
##########
@@ -67,4 +71,6 @@ protected String getDatasetDescriptorPlatform() {
   }
 
   protected abstract TableOperations createTableOperations(TableIdentifier 
tableId);
+
+  protected abstract Table loadTableInstance(TableIdentifier tableId);

Review Comment:
   for good measure you could also make `IcebergTable.TableNotFoundException` a 
declared/checked exception here.
   
   I'm tempted to re-situate the exception as 
`IcebergCatalog.TableNotFoundException`, but I don't want two classes w/ the 
same semantics - and renaming public interfaces is probably too late... so I'll 
make peace with the current name



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@gobblin.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to