phet commented on code in PR #4064:
URL: https://github.com/apache/gobblin/pull/4064#discussion_r1819766989
##########
gobblin-data-management/src/main/java/org/apache/gobblin/data/management/copy/iceberg/IcebergPartitionDatasetFinder.java:
##########
@@ -38,6 +38,9 @@
public class IcebergPartitionDatasetFinder extends IcebergDatasetFinder {
public static final String ICEBERG_PARTITION_NAME_KEY = "partition.name";
public static final String ICEBERG_PARTITION_VALUE_KEY = "partition.value";
+ public static final String
ICEBERG_DATASET_VALIDATE_STRICT_PARTITION_EQUALITY = ICEBERG_DATASET_PREFIX +
"validate.strict.partition.equality";
Review Comment:
considering again the naming through fresh eyes, it ought to be
`partition.validate.strict.equality`, so the fully-qualified form begins w/
`iceberg.dataset.partition.`. that's essentially the type of iceberg dataset
here and if we later have additional configs for iceberg-partition copy, that
should be the common prefix for them all.
the current alt. here mixes the `.partition.` in closer to the end, and
semantics get lost
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@gobblin.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
