abhishekmjain opened a new pull request, #4079:
URL: https://github.com/apache/gobblin/pull/4079

   Dear Gobblin maintainers,
   
   Please accept this PR. I understand that it will not be reviewed until I 
have checked off all the steps below!
   
   
   ### JIRA
   - [ ] My PR addresses the following [Gobblin 
JIRA](https://issues.apache.org/jira/browse/GOBBLIN-2176) issues and references 
them in the PR title. For example, "[GOBBLIN-2176] My Gobblin PR"
       - https://issues.apache.org/jira/browse/GOBBLIN-2176
   
   
   ### Description
   - [ ] Here are some details about my PR, including screenshots (if 
applicable):
   Set default authenticator in Yarn containers if the property is set.
   
   The default authenticator is set in MR world through 
[MRJobLauncher]([MRJobLauncher|https://github.com/apache/gobblin/blob/e5d897edaee391d05a55e6ac8a420e3416fef6d9/gobblin-runtime/src/main/java/org/apache/gobblin/runtime/mapreduce/MRJobLauncher.java#L833).
   
   It gets set in Temporal AM through GobblinTemporalJobLauncher which extends 
GobblinJobLauncher which extends AbstractJobLauncher. AbstractJobLauncher's 
[constructor](https://github.com/apache/gobblin/blob/e5d897edaee391d05a55e6ac8a420e3416fef6d9/gobblin-runtime/src/main/java/org/apache/gobblin/runtime/AbstractJobLauncher.java#L222C7-L222C30)
 sets the default authenticator.
   
   `AbstractJobLauncher.setDefaultAuthenticator()` only performs any action 
when the property `job.default.authenticator.class` is set, or else it is a 
no-op.
   
   ### Tests
   - [ ] My PR adds the following unit tests __OR__ does not need testing for 
this extremely good reason:
   Performed testing in a local Azkaban project.
   
   ### Commits
   - [ ] My commits all reference JIRA issues in their subject lines, and I 
have squashed multiple commits if they address the same issue. In addition, my 
commits follow the guidelines from "[How to write a good git commit 
message](http://chris.beams.io/posts/git-commit/)":
       1. Subject is separated from body by a blank line
       2. Subject is limited to 50 characters
       3. Subject does not end with a period
       4. Subject uses the imperative mood ("add", not "adding")
       5. Body wraps at 72 characters
       6. Body explains "what" and "why", not "how"
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@gobblin.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to