phet commented on code in PR #4079: URL: https://github.com/apache/gobblin/pull/4079#discussion_r1866615709
########## gobblin-temporal/src/main/java/org/apache/gobblin/temporal/cluster/GobblinTemporalTaskRunner.java: ########## @@ -224,6 +225,9 @@ public void start() // Add a shutdown hook so the task scheduler gets properly shutdown addShutdownHook(); + // Update authenticator if set + AbstractJobLauncher.setDefaultAuthenticator(ConfigUtils.configToProperties(this.clusterConfig)); Review Comment: `configToProperties` is somewhat expensive, but since this happens only once at start-up and not in the fast path, that should NOT be a large concern here -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@gobblin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org