abhishekmjain commented on code in PR #4095:
URL: https://github.com/apache/gobblin/pull/4095#discussion_r1943057422
##########
gobblin-temporal/src/main/java/org/apache/gobblin/temporal/GobblinTemporalConfigurationKeys.java:
##########
@@ -74,4 +74,14 @@ public interface GobblinTemporalConfigurationKeys {
String DYNAMIC_SCALING_POLLING_INTERVAL_SECS = DYNAMIC_SCALING_PREFIX +
"polling.interval.seconds";
int DEFAULT_DYNAMIC_SCALING_POLLING_INTERVAL_SECS = 60;
+
+ /**
+ * Temporal metrics config properties
+ */
+ String TEMPORAL_METRICS_PREFIX = PREFIX + "metrics.";
+ String TEMPORAL_METRICS_OTLP_PREFIX_WITHOUT_DOT = TEMPORAL_METRICS_PREFIX +
"otlp";
+ String TEMPORAL_METRICS_OTLP_HEADERS_KEY =
TEMPORAL_METRICS_OTLP_PREFIX_WITHOUT_DOT + ".headers";
+ String TEMPORAL_METRICS_REPORT_INTERVAL_SECS =
TEMPORAL_METRICS_OTLP_PREFIX_WITHOUT_DOT + ".report.interval.seconds";
+ int DEFAULT_TEMPORAL_METRICS_REPORT_INTERVAL_SECS = 10;
+ String TEMPORAL_METRICS_OTLP_DIMENSIONS_KEY =
TEMPORAL_METRICS_OTLP_PREFIX_WITHOUT_DOT + ".dimensions";
Review Comment:
The tags for the metrics. Like let's say we want to filter on flow.name, we
can use that as a dimension and view metrics at individual flow.name level.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@gobblin.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
