abhishekmjain commented on code in PR #4095:
URL: https://github.com/apache/gobblin/pull/4095#discussion_r1943070312
##########
gobblin-temporal/src/main/java/org/apache/gobblin/temporal/GobblinTemporalConfigurationKeys.java:
##########
@@ -74,4 +74,14 @@ public interface GobblinTemporalConfigurationKeys {
String DYNAMIC_SCALING_POLLING_INTERVAL_SECS = DYNAMIC_SCALING_PREFIX +
"polling.interval.seconds";
int DEFAULT_DYNAMIC_SCALING_POLLING_INTERVAL_SECS = 60;
+
+ /**
+ * Temporal metrics config properties
+ */
+ String TEMPORAL_METRICS_PREFIX = PREFIX + "metrics.";
+ String TEMPORAL_METRICS_OTLP_PREFIX_WITHOUT_DOT = TEMPORAL_METRICS_PREFIX +
"otlp";
+ String TEMPORAL_METRICS_OTLP_HEADERS_KEY =
TEMPORAL_METRICS_OTLP_PREFIX_WITHOUT_DOT + ".headers";
+ String TEMPORAL_METRICS_REPORT_INTERVAL_SECS =
TEMPORAL_METRICS_OTLP_PREFIX_WITHOUT_DOT + ".report.interval.seconds";
+ int DEFAULT_TEMPORAL_METRICS_REPORT_INTERVAL_SECS = 10;
+ String TEMPORAL_METRICS_OTLP_DIMENSIONS_KEY =
TEMPORAL_METRICS_OTLP_PREFIX_WITHOUT_DOT + ".dimensions";
Review Comment:
We need to parse headers separately since the default config of header
parsing considers ',' as split value. There may be a header key or value which
needs ',' in its string which will not work if we don't have an object mapper.
For dimension there is no config, have mentioned the benefits in above
comment.
For step, there's a default value of 1 min, which seems a bit longer than
the usual 10 seconds reporting interval.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@gobblin.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
