Blazer-007 commented on code in PR #4092:
URL: https://github.com/apache/gobblin/pull/4092#discussion_r1961792962
##########
gobblin-temporal/src/main/java/org/apache/gobblin/temporal/yarn/AbstractDynamicScalingYarnServiceManager.java:
##########
@@ -110,9 +110,13 @@ public void run() {
List<ScalingDirective> scalingDirectives =
scalingDirectiveSource.getScalingDirectives();
if (CollectionUtils.isNotEmpty(scalingDirectives)) {
dynamicScalingYarnService.reviseWorkforcePlanAndRequestNewContainers(scalingDirectives);
+ } else {
+ dynamicScalingYarnService.calcDeltasAndRequestContainers();
}
} catch (FileNotFoundException fnfe) {
- log.warn("Failed to get scaling directives - " + fnfe.getMessage());
// important message, but no need for a stack trace
+ log.debug("Failed to get scaling directives - " + fnfe.getMessage());
// important message, but no need for a stack trace
Review Comment:
Yes it will be useful for debugging but currently it is getting printed too
many times as background thread is running at an interval of 1 minute that's
why changed to debug log level.
Let me know if we need it to change it back to warn
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@gobblin.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
