khandelwal-prateek commented on code in PR #4092:
URL: https://github.com/apache/gobblin/pull/4092#discussion_r1962841974
##########
gobblin-temporal/src/main/java/org/apache/gobblin/temporal/yarn/AbstractDynamicScalingYarnServiceManager.java:
##########
@@ -110,9 +110,13 @@ public void run() {
List<ScalingDirective> scalingDirectives =
scalingDirectiveSource.getScalingDirectives();
if (CollectionUtils.isNotEmpty(scalingDirectives)) {
dynamicScalingYarnService.reviseWorkforcePlanAndRequestNewContainers(scalingDirectives);
+ } else {
+ dynamicScalingYarnService.calcDeltasAndRequestContainers();
}
} catch (FileNotFoundException fnfe) {
- log.warn("Failed to get scaling directives - " + fnfe.getMessage());
// important message, but no need for a stack trace
+ log.debug("Failed to get scaling directives - " + fnfe.getMessage());
// important message, but no need for a stack trace
Review Comment:
since this is expected in current system design and not a failure as such,
it would be good to change the debug log statement in that case to something
like:
`log.debug("Scaling directives file not found(possibly not yet created).
Falling back to delta calculation.");`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@gobblin.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
