Blazer-007 commented on code in PR #4108:
URL: https://github.com/apache/gobblin/pull/4108#discussion_r2047076545
##########
gobblin-api/src/main/java/org/apache/gobblin/configuration/ConfigurationKeys.java:
##########
@@ -1047,6 +1047,12 @@ public class ConfigurationKeys {
public static final String AZKABAN_FLOW_ID = "azkaban.flow.flowid";
public static final String AZKABAN_JOB_ID = "azkaban.job.id";
public static final String AZKABAN_EXEC_ID = "azkaban.flow.execid";
+ // Configuration Key for setting a unique job execution identifier in GaaS,
the value is a UUID
+ public static final String GAAS_JOB_EXEC_ID = "gaas.job.execid";
+
+ // Configuration Key for to store has of gaas.job.execid, to be used for
jobExecutionId for backwards compatibility
Review Comment:
NIT : `has` -> `hash`
##########
gobblin-service/src/test/java/org/apache/gobblin/service/modules/orchestration/proc/DagProcUtilsTest.java:
##########
@@ -77,6 +78,26 @@ public void testSubmitNextNodesSuccess() throws
URISyntaxException, IOException
}
Mockito.verifyNoMoreInteractions(dagManagementStateStore);
}
+ @Test
Review Comment:
NIT: insert single blank line
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/spec/JobExecutionPlan.java:
##########
@@ -116,6 +117,10 @@ private static JobSpec buildJobSpec(FlowSpec flowSpec,
Config jobConfig, Long fl
String jobName = ConfigUtils.getString(jobConfig,
ConfigurationKeys.JOB_NAME_KEY, "");
String edgeId = ConfigUtils.getString(jobConfig,
FlowGraphConfigurationKeys.FLOW_EDGE_ID_KEY, "");
+ final UUID gaasJobExecutionUUID = UUID.randomUUID();
+ final String gaasJobExecutionId = gaasJobExecutionUUID.toString(); //
Creating a unique Identifier for JobExecution
Review Comment:
NIT: this can be merged into single line
##########
gobblin-modules/gobblin-azkaban/src/main/java/org/apache/gobblin/azkaban/AzkabanJobLauncher.java:
##########
@@ -385,7 +385,11 @@ private boolean isCurrentTimeInRange() {
*/
private static List<? extends Tag<?>> addAdditionalMetadataTags(Properties
jobProps) {
List<Tag<?>> metadataTags = Lists.newArrayList();
- String jobExecutionId = jobProps.getProperty(AZKABAN_FLOW_EXEC_ID, "");
+ String jobExecutionId =
jobProps.getProperty(ConfigurationKeys.GAAS_JOB_EXEC_ID_HASH, "");
Review Comment:
can you update the associated comment below as well on line 414?
`//Use azkaban.flow.execid as the jobExecutionId`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@gobblin.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
