pratapaditya04 commented on code in PR #4108:
URL: https://github.com/apache/gobblin/pull/4108#discussion_r2055553678
##########
gobblin-api/src/main/java/org/apache/gobblin/configuration/ConfigurationKeys.java:
##########
@@ -1047,6 +1047,12 @@ public class ConfigurationKeys {
public static final String AZKABAN_FLOW_ID = "azkaban.flow.flowid";
public static final String AZKABAN_JOB_ID = "azkaban.job.id";
public static final String AZKABAN_EXEC_ID = "azkaban.flow.execid";
+ // Configuration Key for setting a unique job execution identifier in GaaS,
the value is a UUID
+ public static final String GAAS_JOB_EXEC_ID = "gaas.job.execid";
+
+ // Configuration Key for storing hash of gaas.job.execid, to be used as
jobExecutionId(integer) for backwards compatibility
+ public static final String GAAS_JOB_EXEC_ID_HASH =
"gaas.job.executionid.hash";
Review Comment:
The com.typesafe.config maintains config in hierarichal structure, so it
maintains same paths, in the same structure, for it to distinguish
.withValue(ConfigurationKeys.GAAS_JOB_EXEC_ID_HASH,
ConfigValueFactory.fromAnyRef(gaasJobExecutionIdHash))
.withoutPath())
```
it would have been needed to add the config like this, but
In general, it is not recommended to keep two configuration keys with the
same base name (e.g., a.key1 and a.key1.hash) because this can lead to
ambiguity and conflicts within the configuration management system.
```
##########
gobblin-api/src/main/java/org/apache/gobblin/configuration/ConfigurationKeys.java:
##########
@@ -1047,6 +1047,12 @@ public class ConfigurationKeys {
public static final String AZKABAN_FLOW_ID = "azkaban.flow.flowid";
public static final String AZKABAN_JOB_ID = "azkaban.job.id";
public static final String AZKABAN_EXEC_ID = "azkaban.flow.execid";
+ // Configuration Key for setting a unique job execution identifier in GaaS,
the value is a UUID
+ public static final String GAAS_JOB_EXEC_ID = "gaas.job.execid";
+
+ // Configuration Key for storing hash of gaas.job.execid, to be used as
jobExecutionId(integer) for backwards compatibility
+ public static final String GAAS_JOB_EXEC_ID_HASH =
"gaas.job.executionid.hash";
Review Comment:
The com.typesafe.config maintains config in hierarichal structure, so it
maintains same paths, in the same structure, for it to distinguish .```
withValue(ConfigurationKeys.GAAS_JOB_EXEC_ID_HASH,
ConfigValueFactory.fromAnyRef(gaasJobExecutionIdHash))
.withoutPath())
```
```
it would have been needed to add the config like this, but
In general, it is not recommended to keep two configuration keys with the
same base name (e.g., a.key1 and a.key1.hash) because this can lead to
ambiguity and conflicts within the configuration management system.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@gobblin.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
