[
https://issues.apache.org/jira/browse/GOBBLIN-2209?focusedWorklogId=974742&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-974742
]
ASF GitHub Bot logged work on GOBBLIN-2209:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 16/Jul/25 06:17
Start Date: 16/Jul/25 06:17
Worklog Time Spent: 10m
Work Description: abhishekmjain commented on code in PR #4118:
URL: https://github.com/apache/gobblin/pull/4118#discussion_r2209365880
##########
gobblin-metrics-libs/gobblin-metrics/src/main/java/org/apache/gobblin/metrics/opentelemetry/GaaSOpenTelemetryMetrics.java:
##########
@@ -0,0 +1,40 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.gobblin.metrics.opentelemetry;
+
+import lombok.AllArgsConstructor;
+import lombok.Getter;
+
+
+@Getter
+@AllArgsConstructor
+public enum GaaSOpenTelemetryMetrics {
+ GAAS_JOB_STATUS("gaas_job_status", "Gaas job status counter", "1",
OpenTelemetryMetricType.LONG_COUNTER),
Review Comment:
Similarly `s` in the below one?
##########
gobblin-metrics-libs/gobblin-metrics/src/main/java/org/apache/gobblin/metrics/opentelemetry/GaaSOpenTelemetryMetrics.java:
##########
@@ -0,0 +1,40 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.gobblin.metrics.opentelemetry;
+
+import lombok.AllArgsConstructor;
+import lombok.Getter;
+
+
+@Getter
+@AllArgsConstructor
+public enum GaaSOpenTelemetryMetrics {
+ GAAS_JOB_STATUS("gaas_job_status", "Gaas job status counter", "1",
OpenTelemetryMetricType.LONG_COUNTER),
Review Comment:
`1` is metric unit here?
Issue Time Tracking
-------------------
Worklog Id: (was: 974742)
Time Spent: 40m (was: 0.5h)
> Emit GaaS Executor OTel Metrics
> -------------------------------
>
> Key: GOBBLIN-2209
> URL: https://issues.apache.org/jira/browse/GOBBLIN-2209
> Project: Apache Gobblin
> Issue Type: Improvement
> Components: gobblin-metrics
> Reporter: Vivek Rai
> Assignee: Issac Buenrostro
> Priority: Major
> Time Spent: 40m
> Remaining Estimate: 0h
>
> Emit GaaS Executor OTel Metrics
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
