[
https://issues.apache.org/jira/browse/GOBBLIN-2209?focusedWorklogId=974765&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-974765
]
ASF GitHub Bot logged work on GOBBLIN-2209:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 16/Jul/25 08:49
Start Date: 16/Jul/25 08:49
Worklog Time Spent: 10m
Work Description: abhishekmjain commented on code in PR #4118:
URL: https://github.com/apache/gobblin/pull/4118#discussion_r2209706876
##########
gobblin-temporal/src/main/java/org/apache/gobblin/temporal/ddm/launcher/ExecuteGobblinJobLauncher.java:
##########
@@ -96,8 +103,21 @@ public void submitJob(List<WorkUnit> workunits) {
EventSubmitterContext eventSubmitterContext = new
EventSubmitterContext.Builder(eventSubmitter)
.withGaaSJobProps(finalProps)
.build();
+
+ Map<String, String> attributes = new HashMap<>();
+ attributes.put(CURR_STATE, JOB_START);
+ EmitOTelMetricsImpl emitOTelMetrics = new EmitOTelMetricsImpl();
+
emitOTelMetrics.emitLongCounterMetric(GaaSOpenTelemetryMetrics.GAAS_JOB_STATUS,
1L, attributes, finalProps);
+
+ long startTimeMillis = System.currentTimeMillis();
ExecGobblinStats execGobblinStats = workflow.execute(finalProps,
eventSubmitterContext);
+ double timeTaken = (System.currentTimeMillis() - startTimeMillis) /
1000.0;
log.info("FINISHED - ExecuteGobblinWorkflow.execute = {}",
execGobblinStats);
+ attributes.put(CURR_STATE, JOB_COMPLETE);
+
emitOTelMetrics.emitLongCounterMetric(GaaSOpenTelemetryMetrics.GAAS_JOB_STATUS,
1L, attributes, finalProps);
+ attributes.remove(CURR_STATE);
Review Comment:
can you please elaborate on why are we doing this?
Issue Time Tracking
-------------------
Worklog Id: (was: 974765)
Time Spent: 2h (was: 1h 50m)
> Emit GaaS Executor OTel Metrics
> -------------------------------
>
> Key: GOBBLIN-2209
> URL: https://issues.apache.org/jira/browse/GOBBLIN-2209
> Project: Apache Gobblin
> Issue Type: Improvement
> Components: gobblin-metrics
> Reporter: Vivek Rai
> Assignee: Issac Buenrostro
> Priority: Major
> Time Spent: 2h
> Remaining Estimate: 0h
>
> Emit GaaS Executor OTel Metrics
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
