Blazer-007 commented on code in PR #4142:
URL: https://github.com/apache/gobblin/pull/4142#discussion_r2436701618
##########
gobblin-data-management/src/main/java/org/apache/gobblin/data/management/copy/iceberg/IcebergTable.java:
##########
@@ -304,6 +306,13 @@ protected void overwritePartition(List<DataFile>
dataFiles, String partitionColN
} else {
log.warn("~{}~ No current snapshot found before overwrite", tableId);
}
+
+ updateSchema(updatedSchema, false);
+ overwritePartition(dataFiles, partitionColName, partitionValue);
Review Comment:
This partition commit and schema update step should be made similar to what
done in full table i.e. even the destination table schema should not have been
updated in between the job or this should be documented properly and tested as
well
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
