Blazer-007 commented on code in PR #4142:
URL: https://github.com/apache/gobblin/pull/4142#discussion_r2438337247
##########
gobblin-data-management/src/main/java/org/apache/gobblin/data/management/copy/iceberg/IcebergTable.java:
##########
@@ -304,6 +306,13 @@ protected void overwritePartition(List<DataFile>
dataFiles, String partitionColN
} else {
log.warn("~{}~ No current snapshot found before overwrite", tableId);
}
+
+ updateSchema(updatedSchema, false);
+ overwritePartition(dataFiles, partitionColName, partitionValue);
Review Comment:
Okay then lets break this down so that retryer of Overwritepartitionstep
doesn't retry schema update again, might need to refactor
`IcebergOverwritePartitionsStep` to call both function sequentially one after
other
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
