agam-99 opened a new pull request, #4198: URL: https://github.com/apache/gobblin/pull/4198
Dear Gobblin maintainers, Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below! ### JIRA - [x] My PR addresses the following [Gobblin JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR" - https://issues.apache.org/jira/browse/GOBBLIN-2263 ### Description - [x] Here are some details about my PR, including screenshots (if applicable): - Refreshes `dagAction.launch.storeInsertTimeMillis` on each job's `JobSpec` immediately before executor submission, using the current DagAction lease timestamp instead of the original flow LAUNCH timestamp. - Threads the current `LeaseParams` through launch, reevaluate, and resume DagProc submission paths so downstream jobs in multi-hop DAGs measure their own DagAction queueing latency rather than elapsed DAG runtime. - Updates serialized job properties alongside the Typesafe config so `GaaSJobObservabilityEvent` and GridGateway metric emission observe the same fresh anchor. - Uses binary UTF-8 collations for orchestration identifier tables so non-ASCII flow/job identifiers can be compared safely; `dag_node_id`/`parent_dag_id` use `utf8_bin` to stay within MySQL index limits. ### Tests - [x] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason: - Added `DagProcUtilsTest.testSubmitJobToExecutorReplacesStaleStoreInsertTimeMillis` to verify stale anchors are replaced in both `JobSpec` config and properties before submission. - Added `ReevaluateDagProcTest.testCurrentJobToRunReplacesStaleStoreInsertTimeMillis` to cover the downstream REEVALUATE path. - `JAVA_HOME="/Library/Java/JavaVirtualMachines/jdk1.8.0_282-msft.jdk/Contents/Home" ./gradlew :gobblin-service:compileJava :gobblin-service:compileTestJava` - `JAVA_HOME="/Library/Java/JavaVirtualMachines/jdk1.8.0_282-msft.jdk/Contents/Home" ./gradlew :gobblin-service:test --tests "org.apache.gobblin.service.modules.orchestration.proc.DagProcUtilsTest"` - Attempted `JAVA_HOME="/Library/Java/JavaVirtualMachines/jdk1.8.0_282-msft.jdk/Contents/Home" ./gradlew :gobblin-service:test --tests "org.apache.gobblin.service.modules.orchestration.proc.DagProcUtilsTest" --tests "org.apache.gobblin.service.modules.orchestration.proc.ReevaluateDagProcTest" --tests "org.apache.gobblin.service.modules.orchestration.proc.LaunchDagProcTest"`; the suite compiled but failed during `TestMetastoreDatabaseFactory` setup because Docker/Testcontainers is not available in this environment. - `git diff --check` - `mint build` not applicable: this checkout is not a LinkedIn multiproduct directory. ### Commits - [x] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)": 1. Subject is separated from body by a blank line 2. Subject is limited to 50 characters 3. Subject does not end with a period 4. Subject uses the imperative mood ("add", not "adding") 5. Body wraps at 72 characters 6. Body explains "what" and "why", not "how" Made with [Cursor](https://cursor.com) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
