Copilot commented on code in PR #4198:
URL: https://github.com/apache/gobblin/pull/4198#discussion_r3332304593


##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/proc/DagProcUtils.java:
##########
@@ -166,6 +189,22 @@ public static void 
submitJobToExecutor(DagManagementStateStore dagManagementStat
     log.info("Submitted job {} for dagId {}", DagUtils.getJobName(dagNode), 
dagId);
   }
 
+  static void stampDagActionStoreInsertTimeMillis(JobSpec jobSpec, long 
storeInsertTimeMillis) {
+    Config jobConfig = 
jobSpec.getConfig().withoutPath(ConfigurationKeys.DAG_ACTION_LAUNCH_STORE_INSERT_TIME_MILLIS_KEY);
+    if (storeInsertTimeMillis != 
DagActionStore.LeaseParams.UNKNOWN_STORE_INSERT_TIME_MILLIS) {
+      jobConfig = 
jobConfig.withValue(ConfigurationKeys.DAG_ACTION_LAUNCH_STORE_INSERT_TIME_MILLIS_KEY,
+          ConfigValueFactory.fromAnyRef(storeInsertTimeMillis));
+    }
+    jobSpec.setConfig(jobConfig);
+    jobSpec.setConfigAsProperties(ConfigUtils.configToProperties(jobConfig));
+  }

Review Comment:
   `stampDagActionStoreInsertTimeMillis` always removes 
`dagAction.launch.storeInsertTimeMillis` via `withoutPath(...)` even when the 
provided `storeInsertTimeMillis` is `UNKNOWN`. Because the no-arg 
`submitJobToExecutor(...)`/`submitNextNodes(...)` overloads pass `UNKNOWN`, 
callers without lease metadata will now *drop* any pre-existing timestamp in 
the `JobSpec`, changing behavior and potentially removing the latency anchor 
unexpectedly.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to