Blazer-007 commented on code in PR #4206:
URL: https://github.com/apache/gobblin/pull/4206#discussion_r3675523842


##########
gobblin-metrics-libs/gobblin-metrics-base/src/main/avro/GaaSJobObservabilityEvent.avsc:
##########
@@ -264,6 +264,18 @@
                 "type": ["null","string"],
                 "doc": "Whether the dataset passed the overall data quality 
check",
                 "default": null
+              },
+              {
+                "name": "snapshotsCommitted",
+                "type": "long",
+                "doc": "Number of table snapshots committed for the dataset in 
this run (e.g. Iceberg snapshot-replication commits), -1 if unsupported/unknown 
by the writer",
+                "default": -1
+              },
+              {
+                "name": "partitionsCommitted",
+                "type": "long",
+                "doc": "Number of partitions committed for the dataset in this 
run, -1 if unsupported/unknown by the writer",

Review Comment:
   also since it will only contain a single partition , lets name 
`partitionCommitted`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to