pratapaditya04 opened a new pull request, #4206:
URL: https://github.com/apache/gobblin/pull/4206

   Dear Gobblin maintainers,
   
   Please accept this PR. I understand that it will not be reviewed until I 
have checked off all the steps below!
   
   
   ### JIRA
   - [ ] My PR addresses the following [Gobblin 
JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references 
them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
       - https://issues.apache.org/jira/browse/GOBBLIN-XXX
   
   
   ### Description
   - [x] Here are some details about my PR:
   
   Adds per-dataset `snapshotsCommitted` and `partitionsCommitted` counts to 
the observability surfaces so file/blob movement jobs (e.g. Iceberg snapshot 
replication) can report the number of table snapshots and partitions committed 
in a run.
   
   **GaaSJobObservabilityEvent**
   - `GaaSJobObservabilityEvent.avsc`: add `snapshotsCommitted` + 
`partitionsCommitted` to the `DatasetMetric` record (long, default `-1` = 
unsupported/unknown).
   - `DatasetTaskSummary`: carry the two counts as **non-`@NonNull`** long 
fields so the existing 5-arg `@RequiredArgsConstructor` (used by 
`AbstractJobLauncher`) is preserved; they populate via JSON deserialization for 
events that supply them. `toDatasetMetric` maps them onto the regenerated 
`DatasetMetric`.
   
   **Job-status REST API**
   - `JobStatistics.pdl` (executionStatistics): add optional `bytesWritten`, 
`recordsWritten`, `filesCommitted`, `snapshotsCommitted`, `partitionsCommitted`.
   - `JobStatusRetriever`: read them from the flat per-dataset copy-metric keys 
the JobSummary event persists into the job state (`-1` = absent/unsupported).
   - `FlowExecutionResource`: set each on `JobStatistics` only when reported 
(>= 0), so jobs that do not emit them are unchanged.
   
   Backward compatible: all new fields default to `-1`/absent; native Gobblin 
call sites are unchanged.
   
   
   ### Tests
   - [x] My PR adds the following unit tests __OR__ does not need testing for 
this extremely good reason:
   
   Schema/plumbing change validated by codegen + compilation: `generateAvro` 
regenerates `DatasetMetric` (7-arg ctor + fields); `generateDataTemplate` 
regenerates `JobStatistics` setters; `:gobblin-runtime:compileJava` and the 
flow-config-service-server module compile pass. End-to-end population is 
exercised by the companion producer-side change and its unit tests.
   
   
   ### Commits
   - [x] My commits all reference JIRA issues in their subject lines, and I 
have squashed multiple commits if they address the same issue.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to