Siddhi-agg opened a new pull request, #4208:
URL: https://github.com/apache/gobblin/pull/4208

   
   
   Dear Gobblin maintainers,
   
   Please accept this PR. I understand that it will not be reviewed until I 
have checked off all the steps below!
   
   
   ### JIRA
   - [ ] My PR addresses the following [Gobblin 
JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references 
them in the PR title. 
       - https://issues.apache.org/jira/browse/GOBBLIN-XXX
   
   
   ### Description
   - [x] Here are some details about my PR:
   
   The existing KILL path requires an active DAG to locate the executor and its 
submission handle. Once the DAG has been removed, KILL reports that the DAG was 
not found, even if an external execution or launcher is still running.
   
   Retained job status can contain the execution metadata needed to address 
that remaining execution. However, the existing status retrieval APIs convert 
stored State objects into JobStatus objects, which do not preserve arbitrary 
backend-specific metadata.
   
   #### Changes
   
   - Add a backend-neutral ForceKillHandler interface for handling existing 
KILL actions when the active DAG is absent.
   - Allow deployments to supply the handler through 
`gobblin.service.forceKillHandler.class`, using an optional singleton Guice 
binding and service lifecycle hooks.
   - Add raw-state retrieval through JobStatusRetriever and 
MysqlJobStatusRetriever so the fallback can access retained execution metadata 
without converting it into JobStatus.
   - Validate the decoded flow group, flow name, execution ID, and optional job 
scope before passing state copies to the handler. Flow-summary records provide 
context but cannot trigger stopping on their own.
   - Recheck for an active DAG after reading retained state and supply a 
callback for backend-side checks before stopping. If the DAG reappears, return 
to normal cancellation.
   - Distinguish acknowledged, unacknowledged, and active-DAG-present outcomes. 
The retained-state path does not emit normal cancellation events or rewrite 
terminal job status.
   - Include the execution-ID separator in the MySQL lookup pattern so an 
execution such as `1234` does not also match `12340`.
   
   ### Tests
   - [x] My PR adds the following unit tests:
   
   - `KillDagProcForceKillTest`: active-DAG compatibility, retained-state 
scoping, metadata preservation, DAG reappearance, and failure outcomes.
   - `DagProcFactoryForceKillTest`: optional binding, lazy provider access, and 
legacy constructor behavior.
   - `RawJobStatusRetrieverTest`: raw metadata retrieval, execution scoping, 
and read-error propagation.
   - `MysqlJobStatusStateStoreFlowScopeTest`: execution-ID delimiter in the 
MySQL lookup.
   - `GobblinServiceForceKillConfigurationTest`: optional configuration and 
singleton binding.
   - `GobblinServiceForceKillLifecycleTest`: backend cleanup paths.
   
   
   ### Commits
   - [ ] My commits reference the Jira issue, are appropriately squashed, and 
follow the project's commit-message guidelines.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to