Blazer-007 commented on code in PR #4208:
URL: https://github.com/apache/gobblin/pull/4208#discussion_r4089289421


##########
gobblin-api/src/main/java/org/apache/gobblin/service/ServiceConfigKeys.java:
##########
@@ -37,6 +37,7 @@ public class ServiceConfigKeys {
   public static final String GOBBLIN_SERVICE_FLOWSPEC = GOBBLIN_SERVICE_PREFIX 
+ "flowSpec";
   public static final String GOBBLIN_SERVICE_FLOWGRAPH_CLASS_KEY = 
GOBBLIN_SERVICE_PREFIX + "flowGraph.class";
   public static final String GOBBLIN_SERVICE_FLOWGRAPH_HELPER_KEY = 
GOBBLIN_SERVICE_PREFIX + "flowGraphHelper.class";
+  public static final String FORCE_KILL_HANDLER_CLASS_KEY = 
GOBBLIN_SERVICE_PREFIX + "forceKillHandler.class";

Review Comment:
   nit: can we name this `GOBBLIN_SERVICE_FORCE_KILL_HANDLER_CLASS_KEY` ?



##########
gobblin-metastore/src/main/java/org/apache/gobblin/metastore/MysqlJobStatusStateStore.java:
##########
@@ -68,7 +68,8 @@ public MysqlJobStatusStateStore(DataSource dataSource, String 
stateStoreTableNam
    * @throws IOException in case of failures
    */
   public List<T> getAll(String storeName, long flowExecutionId) throws 
IOException {
-    return getAll(storeName, flowExecutionId + "%", 
JobStateSearchColumns.TABLE_NAME_ONLY);
+    return getAll(storeName, flowExecutionId + 
ServiceConfigKeys.STATE_STORE_KEY_SEPARATION_CHARACTER + "%",
+        JobStateSearchColumns.TABLE_NAME_ONLY);
   }

Review Comment:
   Can we check whether adding this can affect earlier callers ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to