yukuai518 commented on a change in pull request #2568: [GOBBLIN-697]
Implementation of data file versioning and preservation in distcp.
URL: https://github.com/apache/incubator-gobblin/pull/2568#discussion_r264956486
##########
File path:
gobblin-data-management/src/main/java/org/apache/gobblin/data/management/copy/publisher/CopyDataPublisher.java
##########
@@ -119,6 +125,12 @@ public CopyDataPublisher(State state) throws IOException {
this.recoveryHelper = new RecoveryHelper(this.fs, state);
this.recoveryHelper.purgeOldPersistedFile();
+
+ Config config = ConfigUtils.propertiesToConfig(state.getProperties());
+
+ this.srcDataFileVersion = DataFileVersionStrategy
+ .instantiateDataFileVersion(HadoopUtils.getSourceFileSystem(state),
config);
+ this.dstDataFileVersion =
DataFileVersionStrategy.instantiateDataFileVersion(this.fs, config);
Review comment:
same dstDataFileVersion => dstDataFileVersionStrategy?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
