yukuai518 commented on a change in pull request #2568: [GOBBLIN-697]
Implementation of data file versioning and preservation in distcp.
URL: https://github.com/apache/incubator-gobblin/pull/2568#discussion_r264946081
##########
File path:
gobblin-data-management/src/main/java/org/apache/gobblin/data/management/copy/publisher/CopyDataPublisher.java
##########
@@ -84,6 +88,8 @@ public boolean isThreadSafe() {
protected final EventSubmitter eventSubmitter;
protected final RecoveryHelper recoveryHelper;
protected final Optional<LineageInfo> lineageInfo;
+ protected final DataFileVersionStrategy srcDataFileVersion;
Review comment:
I think this variable should also be renamed to strategy?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
