arjun4084346 commented on a change in pull request #2589: [GOBBLIN-722] Unschedule gaas flow URL: https://github.com/apache/incubator-gobblin/pull/2589#discussion_r272010852
########## File path: gobblin-runtime/src/main/java/org/apache/gobblin/scheduler/JobScheduler.java ########## @@ -351,8 +351,8 @@ public void scheduleJob(Properties jobProps, JobListener jobListener, Map<String String jobName = jobProps.getProperty(ConfigurationKeys.JOB_NAME_KEY); if (this.scheduledJobs.containsKey(jobName)) { - LOG.warn("Job " + jobName + " has already been scheduled"); - return; + LOG.info("Job " + jobName + " was already scheduled, un-scheduling it now."); + unscheduleJob(jobName); Review comment: because cron-scheduler APIs do not support rescheduling, we have to call cron-scheduler.unschedule first ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services