zxcware commented on a change in pull request #2577: GOBBLIN-708: Create
SqlDatasetDescriptor for JDBC-sourced datasets.
URL: https://github.com/apache/incubator-gobblin/pull/2577#discussion_r272260089
##########
File path:
gobblin-service/src/main/java/org/apache/gobblin/service/modules/dataset/EncryptionConfig.java
##########
@@ -20,18 +20,21 @@
import java.io.IOException;
import com.google.common.base.Enums;
-import com.google.common.base.Joiner;
import com.google.common.collect.ImmutableMap;
import com.typesafe.config.Config;
import com.typesafe.config.ConfigFactory;
+import lombok.EqualsAndHashCode;
import lombok.Getter;
+import lombok.ToString;
import lombok.extern.slf4j.Slf4j;
import
org.apache.gobblin.service.modules.flowgraph.DatasetDescriptorConfigKeys;
import org.apache.gobblin.util.ConfigUtils;
@Slf4j
+@ToString(exclude = {"rawConfig"})
Review comment:
nice
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
