sv2000 commented on a change in pull request #2597: [GOBBLIN-730] added job start and end time in flow status retriever URL: https://github.com/apache/incubator-gobblin/pull/2597#discussion_r275122817
########## File path: gobblin-metrics-libs/gobblin-metrics-base/src/main/java/org/apache/gobblin/metrics/event/TimingEvent.java ########## @@ -78,6 +78,8 @@ public static final String METADATA_DURATION = "durationMillis"; public static final String METADATA_TIMING_EVENT = "timingEvent"; public static final String METADATA_MESSAGE = "message"; + public static final String JOB_START_TIME = "Job Start Time"; + public static final String JOB_END_TIME = "Job End Time"; Review comment: Should this be "jobEndTime"? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
