sv2000 commented on a change in pull request #2597: [GOBBLIN-730] added job
start and end time in flow status retriever
URL: https://github.com/apache/incubator-gobblin/pull/2597#discussion_r275123574
##########
File path:
gobblin-metastore/src/main/java/org/apache/gobblin/metastore/MysqlJobStatusStateStore.java
##########
@@ -55,4 +59,20 @@ public MysqlJobStatusStateStore(DataSource dataSource,
String stateStoreTableNam
return getAll(storeName, flowExecutionId + "%", true);
}
+ @Override
+ public void put(String storeName, String tableName, State state) throws
IOException {
Review comment:
I think the read-modify-write pattern for put() should be ok - since we are
only tracking 5 events per job. Metrics would be helpful though - e.g. total
time spent in put().
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
