sv2000 commented on a change in pull request #2598: [GOBBLIN-731] Make
deserialization of FlowSpec more robust
URL: https://github.com/apache/incubator-gobblin/pull/2598#discussion_r275123940
##########
File path:
gobblin-runtime/src/test/java/org/apache/gobblin/spec_catalog/FlowCatalogTest.java
##########
@@ -117,6 +127,45 @@ public void cleanUp() throws Exception {
}
}
+ /**
+ * Make sure that when there's on spec failed to be deserialized, the rest
of spec in specStore can
+ * still be taken care of.
+ */
+ @Test
+ public void testGetSpecRobustness() throws Exception {
Review comment:
Can the test include reading a 0 byte spec from the specStore? Also, can the
readSpecFromFile() method in TestSpecStore call
SerializationUtils.deserialize() on the 0 byte file? This way we can have it
throw a SerializationException.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
