jhsenjaliya commented on a change in pull request #2609: GOBBLIN-744: Support
cancellation of a Helix workflow via a DELETE Spec.
URL: https://github.com/apache/incubator-gobblin/pull/2609#discussion_r277183004
##########
File path:
gobblin-cluster/src/main/java/org/apache/gobblin/cluster/GobblinHelixJobScheduler.java
##########
@@ -141,6 +143,10 @@ public GobblinHelixJobScheduler(Properties properties,
metricsWindowSizeInMin);
this.startServicesCompleted = false;
+
+ this.helixJobStopTimeoutSeconds =
ConfigUtils.getLong(ConfigUtils.propertiesToConfig(properties),
Review comment:
probably not required to change at this point but i see this usage of
ConfigUtils.propertiesToConfig over an over as if its O(1). may be it needs
separate PR for reusing the created config.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
