jhsenjaliya commented on a change in pull request #2609: GOBBLIN-744: Support
cancellation of a Helix workflow via a DELETE Spec.
URL: https://github.com/apache/incubator-gobblin/pull/2609#discussion_r277183340
##########
File path:
gobblin-cluster/src/main/java/org/apache/gobblin/cluster/GobblinHelixJobScheduler.java
##########
@@ -324,10 +330,17 @@ public void
handleUpdateJobConfigArrival(UpdateJobConfigArrivalEvent updateJobAr
}
@Subscribe
- public void handleDeleteJobConfigArrival(DeleteJobConfigArrivalEvent
deleteJobArrival) {
+ public void handleDeleteJobConfigArrival(DeleteJobConfigArrivalEvent
deleteJobArrival) throws InterruptedException {
LOGGER.info("Received delete for job configuration of job " +
deleteJobArrival.getJobName());
try {
unscheduleJob(deleteJobArrival.getJobName());
+ Properties jobConfig = deleteJobArrival.getJobConfig();
+ if (PropertiesUtils.getPropAsBoolean(jobConfig,
GobblinClusterConfigurationKeys.SHOULD_CANCEL_RUNNING_JOB_ON_DELETE, "false")) {
Review comment:
I think it has to be `False` since to update the job config
`handleUpdateJobConfigArrival` method deletes and insert as new job config. Or
if we want it to be `True` then the method `handleUpdateJobConfigArrival` has
to override this config while updating the jobConfig. #my2Cents.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
