sv2000 commented on a change in pull request #2613: [GOBBLIN-748]Craftsmanship
code cleaning in Gobblin Service Code
URL: https://github.com/apache/incubator-gobblin/pull/2613#discussion_r277525235
##########
File path:
gobblin-service/src/main/java/org/apache/gobblin/service/modules/template_catalog/FSFlowTemplateCatalog.java
##########
@@ -167,4 +159,21 @@ private Config loadHoconFileAtPath(Path filePath, boolean
allowUnresolved)
return ConfigFactory.parseReader(new InputStreamReader(is,
Charsets.UTF_8)).resolve(options);
}
}
+
+ /**
+ * Determine if an URI of a jobTemplate or a FlowTemplate is valid.
+ * @param flowURI The given job/flow template
+ * @return true to continue on loading.
Review comment:
Change to "true if the URI is valid."
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
