sv2000 commented on a change in pull request #2613: [GOBBLIN-748]Craftsmanship
code cleaning in Gobblin Service Code
URL: https://github.com/apache/incubator-gobblin/pull/2613#discussion_r277525100
##########
File path:
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/DagManager.java
##########
@@ -357,10 +357,9 @@ private void initialize(Dag<JobExecutionPlan> dag)
}
/**
- * Poll the statuses of running jobs.
- * @return List of {@link JobStatus}es.
+ * Proceed the execution of each dag node based on job status.
*/
- private void pollJobStatuses()
+ private void proceedDagExecutionOnDagNodeStatus()
Review comment:
Don't like this name. pollAndAdvanceDag() maybe?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
