[
https://issues.apache.org/jira/browse/GOBBLIN-760?focusedWorklogId=235700&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-235700
]
ASF GitHub Bot logged work on GOBBLIN-760:
------------------------------------------
Author: ASF GitHub Bot
Created on: 01/May/19 06:21
Start Date: 01/May/19 06:21
Worklog Time Spent: 10m
Work Description: autumnust commented on pull request #2624:
[GOBBLIN-760] Improve retrying behavior of throttling client, add more
informative …
URL: https://github.com/apache/incubator-gobblin/pull/2624#discussion_r280011772
##########
File path:
gobblin-restli/gobblin-throttling-service/gobblin-throttling-service-client/src/main/java/org/apache/gobblin/util/limiter/BatchedPermitsRequester.java
##########
@@ -196,18 +205,26 @@ private long elapsedMillis(long startTimeNanos) {
/**
* Send a new permit request to the server.
*/
- private void maybeSendNewPermitRequest() {
- if (!this.requestSemaphore.tryAcquire()) {
- return;
+ private synchronized void maybeSendNewPermitRequest() {
+ while (!this.requestSemaphore.tryAcquire()) {
+ if (this.currentCallback == null) {
+ throw new IllegalStateException("Semaphore is unavailable while
callback is null!");
+ }
+ if (this.currentCallback.elapsedTime() > 30000) {
Review comment:
This number seems to be derived from maxTimeOut / (maxRetry + 1) ? Shall we
explicitly place a formula here instead of a plain number
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 235700)
Time Spent: 0.5h (was: 20m)
> Improve retrying behavior of throttling clients
> -----------------------------------------------
>
> Key: GOBBLIN-760
> URL: https://issues.apache.org/jira/browse/GOBBLIN-760
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: Issac Buenrostro
> Assignee: Issac Buenrostro
> Priority: Major
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
