[
https://issues.apache.org/jira/browse/GOBBLIN-760?focusedWorklogId=235867&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-235867
]
ASF GitHub Bot logged work on GOBBLIN-760:
------------------------------------------
Author: ASF GitHub Bot
Created on: 01/May/19 16:32
Start Date: 01/May/19 16:32
Worklog Time Spent: 10m
Work Description: ibuenros commented on pull request #2624: [GOBBLIN-760]
Improve retrying behavior of throttling client, add more informative …
URL: https://github.com/apache/incubator-gobblin/pull/2624#discussion_r280128632
##########
File path:
gobblin-restli/gobblin-throttling-service/gobblin-throttling-service-client/src/main/java/org/apache/gobblin/util/limiter/BatchedPermitsRequester.java
##########
@@ -364,10 +393,22 @@ public void onSuccess(Response<PermitAllocation> result)
{
}
}
+ public long elapsedTime() {
+ return System.currentTimeMillis() - this.startTime;
+ }
+
+ public synchronized void clearCallback() {
Review comment:
We want to make sure a late callback and a timeout don't both release the
semaphore.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 235867)
Time Spent: 50m (was: 40m)
> Improve retrying behavior of throttling clients
> -----------------------------------------------
>
> Key: GOBBLIN-760
> URL: https://issues.apache.org/jira/browse/GOBBLIN-760
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: Issac Buenrostro
> Assignee: Issac Buenrostro
> Priority: Major
> Time Spent: 50m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
