autumnust commented on a change in pull request #2640: [GOBBLIN-775] Add job 
level retries for gobblin service
URL: https://github.com/apache/incubator-gobblin/pull/2640#discussion_r287051518
 
 

 ##########
 File path: 
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/DagManager.java
 ##########
 @@ -457,6 +462,15 @@ private void submitJob(DagNode<JobExecutionPlan> dagNode) 
{
       JobSpec jobSpec = DagManagerUtils.getJobSpec(dagNode);
       Map<String, String> jobMetadata = 
TimingEventUtils.getJobMetadata(Maps.newHashMap(), jobExecutionPlan);
 
+      // Increment submission attempt
 
 Review comment:
   Should this blocked be part of `TimingEventUtils.getJobMetadata` ? 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to