autumnust commented on a change in pull request #2640: [GOBBLIN-775] Add job
level retries for gobblin service
URL: https://github.com/apache/incubator-gobblin/pull/2640#discussion_r287050503
##########
File path:
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/DagManagerUtils.java
##########
@@ -75,8 +75,10 @@ static String getJobName(DagNode<JobExecutionPlan> dagNode)
{
* @return a fully qualified name of the underlying job.
*/
static String getFullyQualifiedJobName(DagNode<JobExecutionPlan> dagNode) {
- Config jobConfig = dagNode.getValue().getJobSpec().getConfig();
+ return
getFullyQualifiedJobName(dagNode.getValue().getJobSpec().getConfig());
+ }
+ public static String getFullyQualifiedJobName(Config jobConfig) {
Review comment:
Let's give it an another name instead.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
