[
https://issues.apache.org/jira/browse/GOBBLIN-806?focusedWorklogId=262549&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-262549
]
ASF GitHub Bot logged work on GOBBLIN-806:
------------------------------------------
Author: ASF GitHub Bot
Created on: 18/Jun/19 18:33
Start Date: 18/Jun/19 18:33
Worklog Time Spent: 10m
Work Description: ZihanLi58 commented on pull request #2672:
[GOBBLIN-806]Enable metrics reporter during dataset discovery for retention job
URL: https://github.com/apache/incubator-gobblin/pull/2672#discussion_r294967654
##########
File path:
gobblin-data-management/src/main/java/org/apache/gobblin/data/management/retention/profile/MultiCleanableDatasetFinder.java
##########
@@ -52,6 +53,10 @@ public MultiCleanableDatasetFinder(FileSystem fs,
Properties jobProps) {
super(fs, jobProps);
Review comment:
In the super class MultiDatasetFinder, the construction
MultiDatasetFinder(fs, jobProps) will create a default eventSubmitter and call
MultiDatasetFinder() which accepts eventSubmitter as an argument. So I think
there is no need to create a default eventSubmitter here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 262549)
Time Spent: 40m (was: 0.5h)
> Enable metrics reporter during dataset discovery for retention job
> ------------------------------------------------------------------
>
> Key: GOBBLIN-806
> URL: https://issues.apache.org/jira/browse/GOBBLIN-806
> Project: Apache Gobblin
> Issue Type: Task
> Reporter: Zihan Li
> Priority: Major
> Time Spent: 40m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
