[
https://issues.apache.org/jira/browse/GOBBLIN-806?focusedWorklogId=262563&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-262563
]
ASF GitHub Bot logged work on GOBBLIN-806:
------------------------------------------
Author: ASF GitHub Bot
Created on: 18/Jun/19 19:00
Start Date: 18/Jun/19 19:00
Worklog Time Spent: 10m
Work Description: sv2000 commented on pull request #2672:
[GOBBLIN-806]Enable metrics reporter during dataset discovery for retention job
URL: https://github.com/apache/incubator-gobblin/pull/2672#discussion_r294978810
##########
File path:
gobblin-data-management/src/main/java/org/apache/gobblin/data/management/retention/profile/MultiCleanableDatasetFinder.java
##########
@@ -52,6 +53,10 @@ public MultiCleanableDatasetFinder(FileSystem fs,
Properties jobProps) {
super(fs, jobProps);
Review comment:
hmm..ok. Can't we change the super class constructor to
MultiDatasetFinder(fs, jobProps, eventSubmitter) and create the submitter in
the MultiCleanableDatasetFinder() constructor and pass it to the parent class?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 262563)
Time Spent: 50m (was: 40m)
> Enable metrics reporter during dataset discovery for retention job
> ------------------------------------------------------------------
>
> Key: GOBBLIN-806
> URL: https://issues.apache.org/jira/browse/GOBBLIN-806
> Project: Apache Gobblin
> Issue Type: Task
> Reporter: Zihan Li
> Priority: Major
> Time Spent: 50m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
