sv2000 commented on a change in pull request #2674: [GOBBLIN-808] implement
azkaban flow cancel when dag manager is enabled
URL: https://github.com/apache/incubator-gobblin/pull/2674#discussion_r296924581
##########
File path:
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/DagManager.java
##########
@@ -267,15 +306,17 @@ public synchronized void setActive(boolean active) {
private JobStatusRetriever jobStatusRetriever;
private DagStateStore dagStateStore;
private BlockingQueue<Dag<JobExecutionPlan>> queue;
+ private BlockingQueue<String> cancelQueue;
/**
* Constructor.
*/
DagManagerThread(JobStatusRetriever jobStatusRetriever, DagStateStore
dagStateStore,
- BlockingQueue<Dag<JobExecutionPlan>> queue, boolean
instrumentationEnabled) {
+ BlockingQueue<Dag<JobExecutionPlan>> queue,
LinkedBlockingDeque<String> cancelQueue, boolean instrumentationEnabled) {
Review comment:
See the comment earlier about using a controlMessageQueue?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services