sv2000 commented on a change in pull request #2674: [GOBBLIN-808] implement azkaban flow cancel when dag manager is enabled URL: https://github.com/apache/incubator-gobblin/pull/2674#discussion_r297438625
########## File path: gobblin-service/src/main/java/org/apache/gobblin/service/modules/spec/JobExecutionPlan.java ########## @@ -61,6 +63,7 @@ private ExecutionStatus executionStatus = ExecutionStatus.$UNKNOWN; private final int maxAttempts; private int currentAttempts = 0; + private Optional<Future> jobFuture = Optional.absent(); Review comment: Should jobFuture be Optional of type CompletableFuture? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
